Fossati, Thomas (Nokia - GB)
2017-03-20 18:39:49 UTC
Dear authors,
Thanks very much for keeping the ball rolling.
I've just finished reading -06 and have few comments. See below.
Cheers, thanks,
t
== S3.1 ==
Last para: the text can be a bit misleading:
“[...] If the CoAP Client has sent a confirmable message, the CoAP Server MUST use a separate SMS message to transmit the ACK.”
The ACK *can* be piggybacked to the response. The MUST is for the sender to not trade an SMS-STATUS-REPORT for an application layer ACK. Might be worth re-phrasing?
== S4 ==
First para:
“[...] the two other encodings are dependent on the language that needs to be encoded [...]”
8-bit data is not dependent on language (in fact it's not intended for text messages).
Second para:
“[...] Since not all MSs support 8 bit short message encoding, the preferred encoding scheme for CoAP messages over SMS is therefore 7 bit, […]”
I'm not sure we should prefer 7-bit over binary. Maybe a better strategy would be to start optimistic (8-bit data) and fall back to one of the 7-bit ASCII encoding variants if that doesn't work. The reasoning is that having 10-20 bytes more here can make a real difference.
When unpacking, how is the receiver supposed to know which of the three different encodings (b64, b85 and ASCII-optimized) has been used by the sender?
== S6 ==
I’m having a bit of trouble with the last para:
“To allow the CoAP client to detect that the short message contains a CoAP message, the TP-DATA-Coding-Scheme SHOULD be included.”
TP-DCS is a mandatory field in both SMS-SUBMIT and SMS-DELIVER messages, how can this be a SHOULD? And: how DCS is supposed to act as an upper layer protocol identifier?
== S7.1 ==
Since the scope is generic "alternative transports", it'd seem wise to also have a Response-To-Uri-Scheme option as well?
"The options SHOULD NOT be used in the response."
Why is this not a MUST NOT? I.e., when is it OK to use these options in a response?
== S8 ==
Do we need muxing? If so, how can this be achieved (e.g., https://tools.ietf.org/html/rfc7925#appendix-A.3)?
== S9 ==
s/RESPONSE_TIMEOUT/ACK_TIMEOUT?
The text is still a tad hand-wavy; I'd like us to provide some guidance at least. Extreme RTT variance is the killer here, but you can usually get around that with a SLA.
(A bit tangent, but another thing that might be worth taking into consideration in the draft is throughput guarantees/requirements.)
== S11 ==
It might be worth adding some text re:
- Spoofing TP-OA (not particularly easy, but certainly possible);
- Adding a reply-address UDH which is different from TP-OA;
- Using DTLS on top of the transport (see RFC 7925).
Thanks very much for keeping the ball rolling.
I've just finished reading -06 and have few comments. See below.
Cheers, thanks,
t
== S3.1 ==
Last para: the text can be a bit misleading:
“[...] If the CoAP Client has sent a confirmable message, the CoAP Server MUST use a separate SMS message to transmit the ACK.”
The ACK *can* be piggybacked to the response. The MUST is for the sender to not trade an SMS-STATUS-REPORT for an application layer ACK. Might be worth re-phrasing?
== S4 ==
First para:
“[...] the two other encodings are dependent on the language that needs to be encoded [...]”
8-bit data is not dependent on language (in fact it's not intended for text messages).
Second para:
“[...] Since not all MSs support 8 bit short message encoding, the preferred encoding scheme for CoAP messages over SMS is therefore 7 bit, […]”
I'm not sure we should prefer 7-bit over binary. Maybe a better strategy would be to start optimistic (8-bit data) and fall back to one of the 7-bit ASCII encoding variants if that doesn't work. The reasoning is that having 10-20 bytes more here can make a real difference.
When unpacking, how is the receiver supposed to know which of the three different encodings (b64, b85 and ASCII-optimized) has been used by the sender?
== S6 ==
I’m having a bit of trouble with the last para:
“To allow the CoAP client to detect that the short message contains a CoAP message, the TP-DATA-Coding-Scheme SHOULD be included.”
TP-DCS is a mandatory field in both SMS-SUBMIT and SMS-DELIVER messages, how can this be a SHOULD? And: how DCS is supposed to act as an upper layer protocol identifier?
== S7.1 ==
Since the scope is generic "alternative transports", it'd seem wise to also have a Response-To-Uri-Scheme option as well?
"The options SHOULD NOT be used in the response."
Why is this not a MUST NOT? I.e., when is it OK to use these options in a response?
== S8 ==
Do we need muxing? If so, how can this be achieved (e.g., https://tools.ietf.org/html/rfc7925#appendix-A.3)?
== S9 ==
s/RESPONSE_TIMEOUT/ACK_TIMEOUT?
The text is still a tad hand-wavy; I'd like us to provide some guidance at least. Extreme RTT variance is the killer here, but you can usually get around that with a SLA.
(A bit tangent, but another thing that might be worth taking into consideration in the draft is throughput guarantees/requirements.)
== S11 ==
It might be worth adding some text re:
- Spoofing TP-OA (not particularly easy, but certainly possible);
- Adding a reply-address UDH which is different from TP-OA;
- Using DTLS on top of the transport (see RFC 7925).